Fix unknown HelmChart OCI build error from unready source#2074
Open
immanuwell wants to merge 1 commit into
Open
Fix unknown HelmChart OCI build error from unready source#2074immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
Stop HelmChart from attempting an OCI chart build when its source HelmRepository is already reporting Ready=False. This keeps the HelmChart failure aligned with the source error instead of surfacing a later generic unknown build error. Signed-off-by: immanuwell <pchpr.00@list.ru> Assisted-by: codex/gpt-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #894
If OCI
HelmRepositoryis alreadyReady=False, the generatedHelmChartstill tries to build from it and ends up with a pretty mehunknown build error.This change stops that early and reuses the source failure reason and message.
Repro:
HelmRepositorywithspec.type: ociand bad creds so it goesReady=False.HelmRelease.HelmChart.Before:
FetchFailed=True, reasonUnknown, messageunknown build error: failed to login to OCI registryAfter:
FetchFailed=True, reasonAuthenticationFailed, messagefailed to login to OCI registryTested with
make tidy fmt vet && make test